DQM code for comparison of Muon and CaloLayer2 input collections between 6 uGT boards

[mzarucki]

Online L1T DQM code used to compare and to ensure that all 6 uGT boards receive the same input data from uGMT and CaloLayer2. The request is summarised in the following JIRA ticket: https://its.cern.ch/jira/browse/CMSLITDPG-329

The code allows for the comparison of the corresponding standard BX collections: Muon, EGamma, EtSum, Jet and Tau, with those that are appended by an index ranging from 2-6, corresponding to the board number.

The code re-uses the existing L1TStage2MuonComp and L1TStage2uGTCaloLayer2Comp L1T DQM modules, so the major change is the addition of a L1TStage2uGTBoardComp_cff.py configuration file fragment. For the CaloLayer2Comp module, minor changes were implemented to generalise the parameter names that are taken as input. It has no effect on the histograms produced for the CaloLayer2 output vs uGT input comparisons (apart from the histogram title).

This additional data is read-out for validation events only, so the DQM module runs in the validation sequence only.

Relevant to this PR is the update to the uGT and CaloLayer2 unpackers, which was required to unpack this new data and fill the relevant object collections: #23257 (Backport to 10_1_X: #23628)

Backport of this PR to 10_1_X: #23695

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23686/5346

[cmsbuild]

A new Pull Request was created by @mzarucki (Mateusz Zarucki) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

@mzarucki Is there any reason to move the jet collections names from specific clear names to probably more confusing names col1 and col2?

[mzarucki]

@jfernan2 As written in the PR description, this is to generalise the parameters of the CaloLayer2Comp DQM module. The specific variable names are simply incorrect if one is to re-use the module for other comparisons (as done here), which I believe is more confusing.

[jfernan2]

Understood, thanks, I was confused by the actual input collections in DQM/L1TMonitor/python/L1TStage2uGTCaloLayer2Comp_cfi.py

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28919/console Started: 2018/06/27 11:01

[cmsbuild]

+1
Tested at: 7365988
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23686/28919/summary.html

[cmsbuild]

Comparison job queued.

[mzarucki]

Here is the backport to 10_1_X: #23695

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23686/28919/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899287
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1