Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-hcx180 Fix a bug for HcalDetId which affects DQM of calibration channels #23688

Merged
merged 1 commit into from Jul 3, 2018

Conversation

bsunanda
Copy link
Contributor

This fix was integrated to 10_2_X master from branch bsunanda:Run2-hcx173

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Jun 26, 2018
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_9_4_X.

It involves the following packages:

DataFormats/HcalDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mariadalfonso, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28911/console Started: 2018/06/26 18:07

@civanch
Copy link
Contributor

civanch commented Jun 26, 2018

@bsunanda , likely you need also back port this fix to 9_3_X (if any effect on SIM step)

@bsunanda
Copy link
Contributor Author

It affects some data related stuff. Mainly for some of the DQM with monitoring data. It will not affect the SIM step

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23688/28911/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 104
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721227
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@bsunanda
Copy link
Contributor Author

It affects some data related stuff. Mainly for some of the DQM with monitoring data. It will not affect the SIM step

@civanch
Copy link
Contributor

civanch commented Jun 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants