New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot module residuals #23723
Plot module residuals #23723
Conversation
it's easy to make mistakes when running on data the only use case of the default 1 is for MC, which is less common
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23723/5378 |
A new Pull Request was created by @tagay (Zhenisbek Tagay) for master. It involves the following packages: Alignment/OfflineValidation @arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Added a function which plots x and y residuals for a specified module. This option is useful when one has to check a particular module which, for instance, moves very far during alignment. (In our case it moved more than by 1 mm)
Post on Hypernews:
https://hypernews.cern.ch/HyperNews/CMS/get/tif-alignment/702.html