Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accessors for setting either pt or e in correctors #2373

Merged
merged 1 commit into from Feb 12, 2014

Conversation

rappoccio
Copy link
Contributor

For future compatibility (and for backwards compatibility with users code) it is useful to set both the E and pt for jet corrections. This has no underlying affect but will allow for possible future developments, and will help users to migrate their code correctly.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2014

A new Pull Request was created by @rappoccio for CMSSW_7_1_X.

Adding accessors for setting either pt or e in correctors

It involves the following packages:

JetMETCorrections/Algorithms

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@vadler
Copy link

vadler commented Feb 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 12, 2014
AT updates -- Adding accessors for setting either pt or e in correctors
@ktf ktf merged commit 6d49765 into cms-sw:CMSSW_7_1_X Feb 12, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@rappoccio rappoccio deleted the rappoccio_JEC_L1_Accessors branch November 3, 2014 21:11
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2373/234/summary.html

The workflows 140.53, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants