Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF emulator fix FW config for 2018 data #23736

Merged
merged 2 commits into from Jul 10, 2018

Conversation

abrinke1
Copy link
Contributor

@abrinke1 abrinke1 commented Jul 3, 2018

10_2_X version of #23727

@cmsbuild cmsbuild changed the base branch from CMSSW_10_2_X to master July 3, 2018 11:15
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

@abrinke1, CMSSW_10_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

A new Pull Request was created by @abrinke1 for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Jul 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28996/console Started: 2018/07/03 17:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23736/28996/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899288
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Jul 10, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

fix of the L1 emulator

@cmsbuild cmsbuild merged commit 276949e into cms-sw:master Jul 10, 2018
@abrinke1 abrinke1 deleted the EMTF_PR_10_2X_DQM_emul_cfg_fix branch September 18, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants