Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for DB credential command line tools #23741

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Jul 4, 2018

In this PR:

  • password inputs for the commands have been obscured
  • init db after creation has been automatically enabled
  • new function for reset the admin password has been added
  • implementation has been generally cleaned up with common helper functions

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23741/5411

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23741/5411/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23741/5411/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

@ggovi
Copy link
Contributor Author

ggovi commented Jul 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29000/console Started: 2018/07/04 12:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/CondDB
CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23741/29000/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Jul 5, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2018

+1

technical utility update

@cmsbuild cmsbuild merged commit dd2b946 into cms-sw:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants