Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material budget empty plots fix #23745

Merged
merged 1 commit into from Jul 18, 2018
Merged

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Jul 4, 2018

Please refer to this issue: #23734

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

A new Pull Request was created by @vargasa (Andres Vargas) for master.

It involves the following packages:

Validation/Geometry

@civanch, @Dr15Jones, @vazzolini, @kmaeshima, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29007/console Started: 2018/07/04 19:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23745/29007/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899287
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@ianna
Copy link
Contributor

ianna commented Jul 9, 2018

+1

@vargasa
Copy link
Contributor Author

vargasa commented Jul 13, 2018

Hi @fabiocos, @jfernan2 Do you have any comments/suggestions/edit_request on this PR? Please let me know. Thanks 👍

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_10_2_X, CMSSW_10_3_X Jul 17, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e5fae77 into cms-sw:master Jul 18, 2018
@vargasa vargasa deleted the EmptyPlotsMatBdg branch September 22, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants