Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relval updates #23748

Merged
merged 3 commits into from Jul 12, 2018
Merged

Relval updates #23748

merged 3 commits into from Jul 12, 2018

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Jul 5, 2018

Update gensim recycling for MC relvals: use GENSIM from pre6
Adding 2018B relval set (+ updated prompt-like GT meant to cover the run 317435 we are using for 2018B relvals)
Adding a NANOAOD wf on 2018 data

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

A new Pull Request was created by @fabozzi for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

The code-checks are being triggered in jenkins.

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 5, 2018

FYI: @arunhep @lpernie

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

Pull request #23748 was updated. @prebello, @arunhep, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @cerminar, @GurpreetSinghChahal, @pohsun, @lpernie can you please check and sign again.

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 5, 2018

please test workflow 136.864

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29015/console Started: 2018/07/05 14:39

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 5, 2018

@akssikdar @pgunnell : FYI

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 5, 2018

@zhenhu

@cmsbuild
Copy link
Contributor

Pull request #23748 was updated. @cmsbuild, @prebello, @zhenhu, @arunhep, @kpedro88, @fabozzi, @pgunnell, @franzoni, @cerminar, @GurpreetSinghChahal, @pohsun, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23748/29066/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23748/136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018+HARVESTNANOAOD2018

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2380 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899490
  • DQMHistoTests: Total failures: 12532
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2886760
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.251 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.251 KiB SiStrip/MechanicalView
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 11, 2018

+1

@arunhep
Copy link
Contributor

arunhep commented Jul 11, 2018

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@arunhep @lpernie @fabozzi this PR changes the GT fro PromptLike, with large effects on the comparison. Could you please document the changes implied by this new tag, and mention it in the PR title? I guess they are the conditions for 2018B, right?

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 11, 2018

The updated GT is meant to cover the run 317435 we are using for 2018B relvals (the v3 GT covers runs up to June 1st). If there are additional GT updates to mention, please reply

@fabiocos
Copy link
Contributor

@fabozzi ok, I see that the differences are all concentrated in the wf 250202.181. So this is likely due to the change of CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1 , am I correct?

@fabozzi
Copy link
Contributor Author

fabozzi commented Jul 11, 2018

@fabiocos
actually this premix workflow is peculiar because it creates from scratch also a (10 events) premix library that is used in the following step3.

Therefore the actual dependence is from:
'CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1',
which points to the MinBias input GENSIM to create the premix library.

In any case, I think we see an effect here because of the small statistics of the premix library (10 events).

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 082ff27 into cms-sw:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants