Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy forwarding for PV and Z->mumu validations #23762

Closed

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jul 6, 2018

backport of #23761

Simple bugfix. I covered most of the validations we run in 84974aa, but missed setting the env variable in these two cases.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_10_1_X.

It involves the following packages:

Alignment/OfflineValidation

@arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@hroskes
Copy link
Contributor Author

hroskes commented Jul 6, 2018

type bug-fix

@pohsun
Copy link

pohsun commented Jul 12, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29099/console Started: 2018/07/12 18:59

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23762/29099/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2523451
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2523274
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@pohsun
Copy link

pohsun commented Jul 13, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@hroskes @pohsun is this PR still needed, or could be closed, as Tier0 has moved to 10_2_X?

@hroskes
Copy link
Contributor Author

hroskes commented Sep 12, 2018

@fabiocos Tier 0 isn't really relevant for us because we run on past samples. On the other hand, I don't think we have any alignment related samples in 101X so I'm ok to close it.

@hroskes hroskes closed this Sep 12, 2018
@hroskes hroskes deleted the tkal-validation-forward-proxy branch October 29, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants