Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing HLTOffline BTV Validation #23771

Merged
merged 3 commits into from Jul 19, 2018
Merged

Fixing HLTOffline BTV Validation #23771

merged 3 commits into from Jul 19, 2018

Conversation

andrzejnovak
Copy link
Contributor

and adding some automation, when script needs to be run manually

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @anovak10 (Andrzej Novak) for master.

It involves the following packages:

HLTriggerOffline/Btag

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@mtosi, @imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

@anovak10 We don't have you identified as DQM developer on:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Btag_and_vertexing
Can you please add yourself to the corresponding e-group in the link above?
Thanks

@andrzejnovak
Copy link
Contributor Author

I don't seem to be able to add myself. @defranchis

@defranchis
Copy link
Contributor

@jfernan2 I just added @anovak10 to the egroup

@jfernan2
Copy link
Contributor

please test
Thanks @defranchis !

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29064/console Started: 2018/07/10 16:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23771/29064/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2894585
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2894392
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12991.203 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 10824.0,... ): 1443.467 KiB HLT/BTV
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@andrzejnovak
Copy link
Contributor Author

bump

@smuzaffar smuzaffar modified the milestones: CMSSW_10_2_X, CMSSW_10_3_X Jul 17, 2018
@fabiocos
Copy link
Contributor

@jfernan2 could you please check and sign in case?

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d16de0c into cms-sw:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants