Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.3.X] HP BS #23818

Merged
merged 1 commit into from Jul 31, 2018
Merged

[10.3.X] HP BS #23818

merged 1 commit into from Jul 31, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Jul 18, 2018

Book keeping for AlcaDB

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented Jul 18, 2018

please test

@lpernie lpernie mentioned this pull request Jul 18, 2018
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29159/console Started: 2018/07/18 16:15

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

CondFormats/Common

@arunhep, @tocheng, @cmsbuild, @franzoni, @cerminar, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 5981885

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23818/29159/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@lpernie
Copy link
Contributor Author

lpernie commented Jul 18, 2018

please test

@lpernie
Copy link
Contributor Author

lpernie commented Jul 19, 2018

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29191/console Started: 2018/07/19 10:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23818/29191/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892290
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892098
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Jul 20, 2018

+1

@fabiocos
Copy link
Contributor

@ggovi could you please check ans sign it in case?

@arunhep
Copy link
Contributor

arunhep commented Jul 22, 2018

@fabiocos
@ggovi is on vacation until July25. This PR is trivial enough to merge if you want to do so.
This change has already been propagated to Express global tag by which we put high performance beamspot as the default BS workflow.

@ggovi
Copy link
Contributor

ggovi commented Jul 30, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5f50d8c into cms-sw:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants