Sign change for translations in the Geometry Comparison Tool

[cardinia]

@hroskes @connorpa as requested I'm tagging you to this commit

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23829/5524

[cmsbuild]

A new Pull Request was created by @cardinia for master.

It involves the following packages:

Alignment/OfflineValidation

@arunhep, @cerminar, @cmsbuild, @franzoni, @tocheng, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29667/console Started: 2018/08/06 11:07

[cmsbuild]

+1
Tested at: 274a926
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23829/29667/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23829/29667/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891565
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2891374
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@cardinia @lpernie sorry, where was this discussed and tested, for my information? The PR tests look insensitive to it

[lpernie]

I let @cardinia and @connorpa comment more on that.

[fabiocos]

hold

pending a clarification from authors and/or AlCa

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

@fabiocos, this change affects exclusively code used for Tracker Alignment internal validations. Is not part of any test suite used in PR tests and doesn't affect any central workflow.
I think it was internally tested by the alignment people: link to presentation

[fabiocos]

unhold

@mmusich thank you for the clarification

[fabiocos]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[hroskes]

Thanks @mmusich for stepping in! Yes, this is just to reverse the y axis on plots. This has been a source of confusion to us for several years. I think this is the 4th time we've flipped the sign. It's correct now.

@fabiocos - what's the recommended procedure for testing in CMSSW? Obviously we have to test things before committing them, but are there formal guidelines for putting everything into the unit tests?

[fabiocos]

@hroskes you may check https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideDevelopersGuide for the suggestions about unit tests. If it is possible to have them in a simple way it sounds useful. In general, if some piece of code is not affecting regular production workflows, it is advisable to clarify whether any kind of standalone test was done and whether it was documented in some way.

[hroskes]

@fabiocos Thanks! We'll keep it in mind.