Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CSCTriggerPrimitivesProducer inherit from edm::one::producer becaus... #2384

Merged
merged 1 commit into from Feb 27, 2014
Merged

make CSCTriggerPrimitivesProducer inherit from edm::one::producer becaus... #2384

merged 1 commit into from Feb 27, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 10, 2014

...e it accesses non-const static CSCTriggerGeometry

…ause it accesses non-const static CSCTriggerGeometry
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

make CSCTriggerPrimitivesProducer inherit from edm::one::producer becaus...

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
@valuev this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Feb 24, 2014

@mulhearn this has been pending for almost two weeks now. Any reason for that?

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@davidlange6
Copy link
Contributor

@mulhearn - ping? [seems trivial]

@mulhearn
Copy link
Contributor

Uggghhh….was waiting for cmsbuild and then it got buried under incoming e-mails...

@mulhearn
Copy link
Contributor

+1

@mulhearn
Copy link
Contributor

Sorry about that.

@mulhearn
Copy link
Contributor

Is there away to check all l1-pending systematically?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 27, 2014
…edm-one-producer

Multithreading fixes -- Make CSCTriggerPrimitivesProducer inherit from edm::one::producer becaus...
@ktf ktf merged commit 11e609e into cms-sw:CMSSW_7_1_X Feb 27, 2014
@gartung gartung deleted the L1Trigger-CSCTriggerPrimitives-edm-one-producer branch February 27, 2014 15:12
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants