Fixed thread problem from reading provenance from file #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provenance reading system in was sharing the ProductProvenanceRetriever between Streams even though the objects have non-const state. Now each Stream has their own ProductProvenanceRetriever instance. In addition, the DaqProvenanceHelper is still shared across Streams. The one piece of state that is being updated was a map which was trivial to change to a tbb::concurrent_unordered_map. In addition, the DaqProvenanceHelper had its member data made private to better encapsulate its functionality. The API change to DaqProvenanceHelper required FedRawDataInputSource to be updated to match.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Fixed thread problem from reading provenance from file It involves the following packages: EventFilter/Utilities @Dr15Jones, @emeschi, @cmsbuild, @nclopezo, @mommsen, @Degano, @ktf can you please review it and eventually sign? Thanks. |
|
+1 |
1 similar comment
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Feb 11, 2014
…eReading Threading Fixes -- Fixed thread problem from reading provenance from file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provenance reading system in was sharing the ProductProvenanceRetriever
between Streams even though the objects have non-const state. Now each
Stream has their own ProductProvenanceRetriever instance. In addition,
the DaqProvenanceHelper is still shared across Streams. The one piece
of state that is being updated was a map which was trivial to change
to a tbb::concurrent_unordered_map. In addition, the DaqProvenanceHelper
had its member data made private to better encapsulate its functionality.
The API change to DaqProvenanceHelper required FedRawDataInputSource
to be updated to match.