Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-hgx131 Add a new scenario with HFNose #23878

Merged
merged 2 commits into from Jul 25, 2018
Merged

Phase2-hgx131 Add a new scenario with HFNose #23878

merged 2 commits into from Jul 25, 2018

Conversation

bsunanda
Copy link
Contributor

No description provided.

@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Jul 19, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23878/5571

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData

@cmsbuild, @prebello, @Dr15Jones, @zhenhu, @ianna, @mdhildreth, @fabozzi, @pgunnell, @franzoni, @kpedro88, @civanch, @GurpreetSinghChahal, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

kpedro88
kpedro88 reviewed Jul 19, 2018
View reviewed changes
Configuration/Geometry/python/dict2023Geometry.py Outdated
@@ -562,7 +562,7 @@
1 : [
'Geometry/ForwardCommonData/data/forwardshield/2017/v1/forwardshield.xml',
'Geometry/ForwardCommonData/data/brmrotations.xml',
'Geometry/ForwardCommonData/data/PostLS2/brm.xml',
'Geometry/ForwardCommonData/data/brm/2023/v1/brm.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda why did you make this change in F2? This will affect all the Phase2 geometries.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23878/5572

@cmsbuild
Copy link
Contributor

Pull request #23878 was updated. @cmsbuild, @prebello, @Dr15Jones, @zhenhu, @ianna, @mdhildreth, @fabozzi, @pgunnell, @franzoni, @kpedro88, @civanch, @GurpreetSinghChahal, @fabiocos, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29233/console Started: 2018/07/20 00:45

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29263/console Started: 2018/07/20 17:35

@cmsbuild
Copy link
Contributor

+1
Tested at: b3d4050
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23878/29263/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23878/29263/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892290
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892099
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@kpedro88
Copy link
Contributor

+upgrade
(I privately tested new WF 26234.0, including #23810 for the topology class, and it runs successfully.)

@ianna
Copy link
Contributor

ianna commented Jul 24, 2018

+1

@kpedro88
Copy link
Contributor

@prebello @fabozzi please sign

@prebello
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 043f941 into cms-sw:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available geometry-approved operations-pending orp-approved pdmv-approved pending-signatures tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_3_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bsunanda @cmsbuild @davidlange6 @kpedro88 @ianna @prebello