backport of CASTOR updates on rechitcorrector and noise simulation #23894
Conversation
|
A new Pull Request was created by @hvanhaev (Hans Van Haevermaet) for CMSSW_8_0_X. It involves the following packages: RecoLocalCalo/Castor @perrotta, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
please test |
|
The tests are being triggered in jenkins. |
|
@hvanhaev is this backport targeting a dedicated production of 2016 new simulation? |
|
Dear Fabio,
At the moment we did not yet plan a dedicated production, but it would be good to have this code integrated for future requests.
Thanks,
Hans
On 20 Jul 2018, at 14:06, Fabio Cossutti <notifications@github.com<mailto:notifications@github.com>> wrote:
@hvanhaev<https://github.com/hvanhaev> is this backport targeting a dedicated production of 2016 new simulation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23894 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEgkF1srfCeExiSeKxPXIvnhjm5if_Pwks5uIce2gaJpZM4VX60c>.
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| } | ||
| } | ||
|
|
||
| if (ok) { | ||
| CastorRecHit *correctedhit = new CastorRecHit(rechit.id(),correctedenergy,time); | ||
| rec->push_back(*correctedhit); | ||
| rec->emplace_back(rechit.id(),correctedenergy,time); |
There was a problem hiding this comment.
@hvanhaev , is it correct? I would think about "rec->emplace_back(new CastorRecHit(....))"
There was a problem hiding this comment.
There is no need for new. One could think of explicitly calling a constructor emplace_back(CastorRecHit(..., but that's the same as what it is now.
the old implementation collected copies of the hits (type CastorRecHit). The updated version does exactly the same. and also avoids a memory leak that was there before.
There was a problem hiding this comment.
No, using new here is totally unnecessary and in fact it's a memory leak. rec is a CastorRecHitCollection and it can construct the CastorRecHit objects from arguments using emplace_back().
there are changes in the default reconstruction in the castor energies etc. E.g. in ZMM workflow 1330.0. Given that this is 8_0 and it's CASTOR, perhaps an exception can be discussed. It would be nice to understand if there still can be a solution following the policy. |
|
+1 |
|
Dear Slava,
I’m not able to check the workflow in details now, but in case of simulation changes in energy are expected as the simulation update contains a bug fix that adjusts noise treatment. For data, no changes in default workflow are expected.
The bug fix for the noise is implemented in code, I’m not sure how this could be changed to use configuration files.
Cheers,
Hans
On 24 Jul 2018, at 17:32, Slava Krutelyov <notifications@github.com<mailto:notifications@github.com>> wrote:
Reco comparison results: 29 differences found in the comparisons
there are changes in the default reconstruction in the castor energies etc. E.g. in ZMM workflow 1330.0.
This violates the nominal policy for production releases: default behavior should remain unchanged and if changed behavior is needed, it should be made available via a configuration change.
Given that this is 8_0 and it's CASTOR, perhaps an exception can be discussed. It would be nice to understand if there still can be a solution following the policy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23894 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEgkF2AuJuzBB-SV6gkrd2SoHVhu0er5ks5uJz3CgaJpZM4VX60c>.
|
|
backport of #22424 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
|
merge @civanch you already signed this PR, the further change just keeps the default behaviour, in case please sign it again anyway |
This is a back port of changes already included in the master, as discussed in PR: #22424
This contains a fix in the CASTOR noise simulation, and updates in the rechitcorrector module.
It would be good to have these too in CMSSW_80X for analyses with 2016 data.