CMSLITDPG-612: Removed data v. emul. comparison bug

[vukasinmilosevic]

Removing the duplicated (bug) code in the data vs emulator DQM comparison code, as well as fixing the MHTPhi plots by removing the peak coming from the default value (by inserting Pt>0 requirement).

Backport of #23971

[cmsbuild]

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for CMSSW_10_2_X.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from CMSLITDPG-612: Removed data v. emul. comparison bug #23971

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29326/console Started: 2018/07/23 12:49

[cmsbuild]

+1
Tested at: ba4a9f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23943/29326/summary.html

[cmsbuild]

Comparison job queued.

[thomreis]

Hi @vukasinmilosevic
do you also have a PR to the master branch and a second backport PR to the 10_1_X branch?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23943/29326/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892290
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892095
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[thomreis]

backport of #23971

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29704/console Started: 2018/08/07 10:53

[cmsbuild]

+1
Tested at: ba4a9f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23943/29704/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23943/29704/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892884
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892689
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

+1