DAQ file broker client (10_1_X) #23948

smorovic · 2018-07-23T12:19:07Z

Backport of #23944 (10_3_X)
Client implementation for new DAQ File Broker protocol

Tested in DAQ production HLT based on CMSSW_10_1_7 (and is remaining deployed for MD2 period).

…ile service which will distribute input files

Signed-off-by: Srecko Morovic <srecko.morovic@cern.ch>

catch file not exists and check for run directory on BU handle NORUN fix READY with no file current LS handle JSON file move by server to subdirectory with prefix

support for socket keep alive (experimental)

fix undefined variable value when no raw file use shared lock for server contact and promote it to exclusive if EoLS file(s) have to be written

…ase of deletion of the run directory

access to copy JSON file from ramdisk. This allows better diagnosis of problems (such as recently seen bad file descriptor problem in some tests). This is enabled only for File Broker, while NFS locking code remains unchanged (as it is going to be phased out).

keep alive by default close socket on error NB: in tests it turns out that read_until reads the whole response. this is however not always guaranteed and updates will be needed to read based on HTTP Content-Length

cmsbuild · 2018-07-23T12:19:26Z

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_10_1_X.

It involves the following packages:

EventFilter/Utilities

@perrotta, @mommsen, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from DAQ file broker client (10_3_X) #23944

mommsen · 2018-07-23T13:18:47Z

please test

cmsbuild · 2018-07-23T13:19:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29336/console Started: 2018/07/23 15:21

cmsbuild · 2018-07-23T15:23:32Z

+1
Tested at: 660ad17
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23948/29336/summary.html

cmsbuild · 2018-07-23T15:23:35Z

Comparison job queued.

cmsbuild · 2018-07-23T16:30:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23948/29336/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2520647
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2520470
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
Checked 119 log files, 9 edm output root files, 29 DQM output files

mommsen · 2018-07-23T17:15:41Z

+1

slava77 · 2018-07-24T18:11:53Z

backport of #23944

slava77 · 2018-07-24T18:13:28Z

+1

for #23948 660ad17

the backport is correct (comparing to DAQ file broker client (10_3_X) #23944 4c7f2cd : only some of the removed code in EventFilter/Utilities/src/FedRawDataInputSource.cc differs by const& in two catch arguments; the changes are identical to the changes in the 102X version DAQ file broker client (10_2_X) #23947 09f835c
). The code changes are not really related to reco and do not affect the standard workflows tested offline.
jenkins tests pass

cmsbuild · 2018-07-24T18:13:48Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

kpedro88 · 2018-07-25T15:26:59Z

+1

smorovic added 20 commits July 23, 2018 14:09

reorganizing source and service to support both old locking and new f…

e9b7f55

…ile service which will distribute input files

2nd part of modifications to support new FFF file service interface

e291f0c

handle max LS (cloud stopping) and updates to the API

63ce8d6

fixes to file locking and changes to the file service protocol

4701455

back off mechanism to reduce number of open sockets in BU service

390fbba

allow stop LS 0

fdf533b

Signed-off-by: Srecko Morovic <srecko.morovic@cern.ch>

logging for stop LS

cc1e54a

pid added to HTTP attributes (for possible use in renaming)

af12ed4

catch file not exists and check for run directory on BU handle NORUN fix READY with no file current LS handle JSON file move by server to subdirectory with prefix

support for optional unlocking

06b3b6d

support for socket keep alive (experimental)

rename fileService to fileBroker

1c195b2

fix undefined variable value when no raw file use shared lock for server contact and promote it to exclusive if EoLS file(s) have to be written

write EoLS files before index files from next LS are written locally

ddf6fb9

remove shared lock implementation which doesn't work correctly

f1c4433

removing unused lock file function

6369f5d

proper error recovery (avoiding assertions, segmentation faults) in c…

3bd673e

…ase of deletion of the run directory

Use HTTP 1.1 as it will be needed for keep alive

0e3d42c

fix for keep-alive

41259e2

2nd round of keep-alive fixes

64673f5

keep alive by default close socket on error NB: in tests it turns out that read_until reads the whole response. this is however not always guaranteed and updates will be needed to read based on HTTP Content-Length

catching const& exceptions

81235d6

remove double const

660ad17

cmsbuild added this to the CMSSW_10_1_X milestone Jul 23, 2018

cmsbuild added comparison-pending daq-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 23, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2018

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2018

cmsbuild added daq-approved and removed daq-pending labels Jul 23, 2018

cmsbuild added the backport label Jul 24, 2018

cmsbuild added fully-signed reconstruction-approved backport-ok and removed pending-signatures reconstruction-pending backport labels Jul 24, 2018

cmsbuild added orp-approved and removed orp-pending labels Jul 25, 2018

cmsbuild merged commit afa1bf9 into cms-sw:CMSSW_10_1_X Jul 25, 2018

smorovic deleted the newFileServer-10_1_X branch August 23, 2018 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAQ file broker client (10_1_X) #23948

DAQ file broker client (10_1_X) #23948

smorovic commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 •

edited

mommsen commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 •

edited

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

mommsen commented Jul 23, 2018

slava77 commented Jul 24, 2018

slava77 commented Jul 24, 2018

cmsbuild commented Jul 24, 2018

kpedro88 commented Jul 25, 2018

DAQ file broker client (10_1_X) #23948

DAQ file broker client (10_1_X) #23948

Conversation

smorovic commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 • edited

mommsen commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 • edited

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

mommsen commented Jul 23, 2018

slava77 commented Jul 24, 2018

slava77 commented Jul 24, 2018

cmsbuild commented Jul 24, 2018

kpedro88 commented Jul 25, 2018

cmsbuild commented Jul 23, 2018 •

edited

cmsbuild commented Jul 23, 2018 •

edited