Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to HLT menu 3p2 with muon fix (102X) #23950

Merged
merged 5 commits into from Jul 28, 2018
Merged

Update to HLT menu 3p2 with muon fix (102X) #23950

merged 5 commits into from Jul 28, 2018

Conversation

silviodonato
Copy link
Contributor

Backport of #23949

@silviodonato
Copy link
Contributor Author

hold

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jul 23, 2018
@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29339/console Started: 2018/07/23 16:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2018 •
edited

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_10_2_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #23950 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3c2fff1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23950/29339/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29348/console Started: 2018/07/23 20:10

@cmsbuild
Copy link
Contributor

+1
Tested at: e36e4e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23950/29348/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29380/console Started: 2018/07/24 11:36

@cmsbuild
Copy link
Contributor

+1
Tested at: 2a9eabd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23950/29380/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b8a7a96
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23950/29380/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23950/29380/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23950/29380/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892086
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2891845
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 125.656 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 136.85 ): 45.658 KiB HLT/EGM
  • DQMHistoSizes: changed ( 136.85,... ): -5.246 KiB HLT/JME
  • DQMHistoSizes: changed ( 136.85,... ): 1.452 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 250202.181,... ): 45.689 KiB HLT/EGM
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@silviodonato
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Jul 25, 2018
@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

@Dr15Jones
also sign this backport, please!

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d00b7b4 into cms-sw:CMSSW_10_2_X Jul 28, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLT_3p2_102X_muonFix branch November 17, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available core-approved fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silviodonato @cmsbuild @Martin-Grunewald @Dr15Jones @kpedro88