New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1T DQM Plots for Kalman Filter for BMTF - backport - CMSSW_10_1_X #23953

Closed

ghost wants to merge 2 commits into cms-sw:CMSSW_10_1_X from unknown repository

ghost commented Jul 23, 2018

New DQM Plots for Kalman Filter. The whole task is based on Kalman DQM BMTF


          Kalman new plots - backport

9690ee4

Author

ghost commented Jul 23, 2018

backport of #23389

cmsbuild added this to the CMSSW_10_1_X milestone

cmsbuild added backport-ok comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels

Contributor

cmsbuild commented Jul 23, 2018 •

edited

A new Pull Request was created by @dtsitson for CMSSW_10_1_X.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
EventFilter/L1TRawToDigi

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from L1T DQM Plots for Kalman Filter for BMTF - CMSSW_10_2_X #23389

Contributor

thomreis commented Jul 23, 2018

please test

Contributor

cmsbuild commented Jul 23, 2018 •

edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29358/console Started: 2018/07/23 23:32

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Jul 24, 2018

+1
Tested at: 9690ee4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23953/29358/summary.html

Contributor

cmsbuild commented Jul 24, 2018

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Jul 24, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23953/29358/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2520647
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2520470
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 21751.44 KiB( 28 files compared)
DQMHistoSizes: changed ( 150.0,... ): 1793.399 KiB L1T/L1TStage2BMTF
DQMHistoSizes: changed ( 150.0,... ): 19.221 KiB L1TEMU/L1TdeStage2BMTF
Checked 119 log files, 9 edm output root files, 29 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

thomreis suggested changes

View reviewed changes

Contributor

thomreis left a comment

There are some calo layer 2 related changes that are not part of the master PR and that should be removed.

DQM/L1TMonitor/python/L1TStage2Emulator_cff.py Outdated

@@ @@ -88,11 +99,15 @@ @@
               # CaloLayer2
               from DQM.L1TMonitor.L1TdeStage2CaloLayer2_cfi import *
+              from DQM.L1TMonitor.L1TStage2CaloLayer2_cfi import *

Contributor

thomreis Jul 24, 2018

Please remove the calo layer2 related code changes.

DQM/L1TMonitor/python/L1TStage2Emulator_cff.py Outdated

@@ @@ -122,7 +138,10 @@ @@
               # sequence to run only for validation events
               l1tStage2EmulatorOnlineDQMValidationEvents = cms.Sequence(
                   l1tdeStage2CaloLayer1 +
+                  # We process both layer2 and layer2emu in same sourceclient

Contributor

thomreis Jul 24, 2018

Please remove the calo layer2 related code changes.

DQM/L1TMonitor/python/L1TStage2Emulator_cff.py Outdated

		l1tdeStage2CaloLayer2 +
		l1tStage2CaloLayer2 +

Contributor

thomreis Jul 24, 2018

Please remove the calo layer2 related code changes.

DQM/L1TMonitorClient/python/L1TStage2EmulatorMonitorClient_cff.py Outdated

@@ @@ -17,6 +17,7 @@ @@
               from DQM.L1TMonitorClient.L1TStage2EmulatorQualityTests_cff import *
               # Calo trigger layer2 client
+              from DQM.L1TMonitorClient.L1TStage2CaloLayer2DEClient_cfi import *

Contributor

thomreis Jul 24, 2018

Please remove the calo layer2 related code changes.

DQM/L1TMonitorClient/python/L1TStage2EmulatorMonitorClient_cff.py Outdated

@@ @@ -43,9 +47,11 @@ @@
               # L1T monitor client sequence (system clients and quality tests)
               l1TStage2EmulatorClients = cms.Sequence(
-              		        l1tStage2CaloLayer2DEClientSummary
+                                      l1tStage2CaloLayer2DEClient

Contributor

thomreis Jul 24, 2018

Please remove the calo layer2 related code changes.


          Fix the problems from previous SW

cf79a99

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels

Contributor

cmsbuild commented Jul 24, 2018

Pull request #23953 was updated. @cmsbuild, @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis can you please check and sign again.

Contributor

thomreis commented Jul 24, 2018

+1

cmsbuild added l1-approved and removed l1-pending labels

Contributor

cmsbuild commented Jul 24, 2018 •

edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29378/console Started: 2018/07/24 10:36

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Jul 24, 2018

+1
Tested at: cf79a99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23953/29378/summary.html

Contributor

cmsbuild commented Jul 24, 2018

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Jul 24, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23953/29378/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2520647
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2520470
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 21751.44 KiB( 28 files compared)
DQMHistoSizes: changed ( 10042.0,... ): 1793.399 KiB L1T/L1TStage2BMTF
DQMHistoSizes: changed ( 10042.0,... ): 19.221 KiB L1TEMU/L1TdeStage2BMTF
Checked 119 log files, 9 edm output root files, 29 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

andrius-k commented Jul 24, 2018

+1

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels

Contributor

cmsbuild commented Jul 24, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Contributor

thomreis commented Aug 22, 2018

Hi @dtsitson
this PR can be close now that the online DQM has moved to the 10_2 release.

ghost closed this

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment