Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgcal xml files #2399

Merged
merged 7 commits into from Feb 14, 2014
Merged

Conversation

vandreev11
Copy link
Contributor

HGCal concept geometry, version number 2, for eta3 and eta4
Valeri Andreev 11.02.2014

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC.

Hgcal xml files

It involves the following packages:

DataFormats/ForwardDetId
Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HGCalSimData
SimG4CMS/Calo

The following packages do not have a category, yet:

DataFormats/ForwardDetId
Geometry/HGCalSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Feb 11, 2014

+1

@mark-grimes
Copy link

merge

Extended pixel GEN-SIM okay. GEM test okay. 3300, 3400, 4100, 4400, 40001, 50002, 60002, 4502, 4500, 5001 and 15001 all pass. Didn’t test 60001 or 50001 because of known errors.
Currently don't have a test for HGCal but nothing existing is broken.

cmsbuild added a commit that referenced this pull request Feb 14, 2014
@cmsbuild cmsbuild merged commit 131bdfe into cms-sw:CMSSW_6_2_X_SLHC Feb 14, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
toolfile fixes for sherpa, scons and setuptools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants