Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53X - add CSCTightHaloFilter #2402

Merged
merged 1 commit into from Feb 26, 2014

Conversation

vadler
Copy link

@vadler vadler commented Feb 11, 2014

Minimal backport of CSCTightHaloFilter from 62X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_5_3_X.

53X - add CSCTightHaloFilter

It involves the following packages:

RecoMET/METFilters

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link
Author

vadler commented Feb 11, 2014

@TaiSakuma : This is just minimal to get the CSC halo filter away from the METAnalyzers. I do not consider the filters added in 62X also necessary here, right?

@vadler vadler mentioned this pull request Feb 11, 2014
@TaiSakuma
Copy link
Contributor

@vadler, right. I don't think it is necessary.

Incidentally, METAnalyzers has been part of MET recipe for 53X just to provide the CSC filter:
TaiSakuma/cmssw@cms-sw:CMSSW_5_3_14...53X-met-131120-01
Now, I can remove METAnalyzers from the recipe.

@vadler
Copy link
Author

vadler commented Feb 11, 2014

I am on the way to provide a special branch for recipes as long as this one is not integrated yet. Hold on for a few minutes...

@vadler
Copy link
Author

vadler commented Feb 11, 2014

@TaiSakuma : https://github.com/cms-analysis-tools/cmssw/compare/cms-sw:CMSSW_5_3_15...5_3_15-addCSCTightHaloFilter?expand=1 on the basis of CMSSW_5_3_15.
I have added you to https://github.com/orgs/cms-analysis-tools/teams/development , so you can update/modify it yourself, if desired.

@TaiSakuma
Copy link
Contributor

@vadler, ok. Thanks.

@vadler
Copy link
Author

vadler commented Feb 11, 2014

+1
Tested application of filter with recipe in
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideTopRefEventSel#CMSSW_5_3_15

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1

smuzaffar added a commit that referenced this pull request Feb 26, 2014
@smuzaffar smuzaffar merged commit 0f2d78e into cms-sw:CMSSW_5_3_X Feb 26, 2014
@vadler vadler deleted the 53X-addCSCTightHaloFilter branch May 21, 2014 11:25
@slava77 slava77 mentioned this pull request Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants