New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made CSCDigiToRawModule a global module #24052
Made CSCDigiToRawModule a global module #24052
Conversation
Removed the need for updating member data during the calculations. This allowed all methods to become const and makes the class const thread safe.
By converting CSCDigiToRaw to be const thread safe, the module CSDDigiToRawModule could be converted to a global.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24052/5737 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: EventFilter/CSCRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 9fd8aa0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The CSCDigiToRawModule is showing up as a time consuming legacy module in the DIGI workflow and was affecting the CPU efficiency.