Make SiPixelDigiToRaw a global module #24057
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24057/5740 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: EventFilter/SiPixelRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| edm::EventSetup const& es) const { | ||
| while(lock_.test_and_set(std::memory_order_acquire)); //spin | ||
| auto rel = [](std::atomic_flag* f) { f->clear(std::memory_order_release); }; | ||
| std::unique_ptr<std::atomic_flag, decltype(rel)> guard(&lock_, rel); |
There was a problem hiding this comment.
I wish there were a simpler version compared to these 3 lines.
There was a problem hiding this comment.
If you prefer, we could switch to a boost spinlock
https://www.boost.org/doc/libs/1_54_0/doc/html/atomic/usage_examples.html#boost_atomic.usage_examples.example_spinlock.usage
but that would add a dependency on boost.
|
@Dr15Jones |
|
I think this is OK.
If I remember right the simple accumulation has not been used for a while.
Also the CPU histograms we have not been looking at them recently.
There are probably other tools which can measure the CPU usage better now.
Danek
… On 31 Jul 2018, at 20:10, Slava Krutelyov ***@***.***> wrote:
@tsusa @dkotlins @veszpv
please note that this PR removes some statistics accumulation functionality from SiPixelDigiToRaw:
• simple accumulation of input digis
• CPU timing histogramming
Both were not a part of the default configuration.
Please confirm that the removal is OK.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Also removed filling of timing and digi counts histograms, as those can not be done in a thread efficent manner.