AMPT bug (related to #23573) fixing

[wouf]

Fixing AMPT bug related to #23573 warning.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24125/5815

[cmsbuild]

A new Pull Request was created by @wouf for master.

It involves the following packages:

GeneratorInterface/AMPTInterface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[alberto-sanchez]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29553/console Started: 2018/07/30 05:00

[cmsbuild]

+1
Tested at: fb22df7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24125/29553/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24125/29553/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891493
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2891300
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@wouf thank you for this, the fix looks trivial and safe. Which real test on a ampt workflow was done? This code is not run in the usual PR tests, and I guess we have not even relvals for it

[wouf]

@fabiocos I tested it with CMSSW_10_2_0_pre5 - it worked fine.

[fabiocos]

@wouf thank you, I assume it worked fine also from the physics output point of view, did you produce some validation plot?

[wouf]

@fabiocos No no physical related changes was made. The changes is made for the case of ISUB=161, which is a process of the Higgs sector. AMPT author's limited tests shows that this location is never reached. To check if this right Zi-Wei (original AMPT author), asked to put the "stop" command here (and report to him if this unexpected case will happend), so in this version simulation will abort here.

[fabiocos]

@wouf ok, thank you

[fabiocos]

+1