Make L1TMuonOverlapTrackProducer a one module

[Dr15Jones]

The L1TMuonOverlapTrackProducer is showing up as stalling during DIGI workflows.

The module could not be made into a stream module since it has a mode where it can write out an XML file. I highly recommend that this mode be removed so a more thread efficient module type can be used.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24133/5821

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/L1TMuonOverlap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29565/console Started: 2018/07/30 17:53

[cmsbuild]

+1
Tested at: b60b10b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24133/29565/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24133/29565/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891493
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2891301
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[thomreis]

Hi @konec
do you think there is a possibility to move the writing of the XML to some other place in order to be able to make this a stream module?

[thomreis]

+1
We are discussing internally how this could be made a stream module. The writing to XML is a mode that is only used in expert operation and not in production. @Dr15Jones could a stream module be acting as a one module depending on a configuration parameter?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[Dr15Jones]

@thomreis since deciding on a ::one or ::global depends on inheritance, it is not possible to change their type based on configuration.

[konec]

@Dr15Jones, @thomreis
XML writing is there only for debugs, used by experts, not in normal production running.
If it is not possible to keep there this XML writer, maybe it can be hide under #ifndef ?
(ie. two constructors). Otherwise please remove XML part, we will add additional producer with XML code.
@akalinow