castor dqm update #24142

popovvp · 2018-07-31T10:56:13Z

rm CastorBaseMonitor module
removed some TH2D histograms :
instead of 2xTH2D add TProfile
add Energy (digi) vs BX (latency)
re-implement DB conditions for masking

cmsbuild · 2018-07-31T10:56:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-07-31T11:00:28Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5829

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5829/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5829/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2018-07-31T11:08:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-07-31T11:12:26Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5830

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5830/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5830/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2018-07-31T11:36:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-07-31T11:38:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5831

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5831/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/5831/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

andrius-k · 2018-08-07T10:15:28Z

Hi,

Are you sure that code checks in this case didn't pass because of the bot error? Could you please review the code one more time?

popovvp · 2018-08-08T08:44:26Z

Hi, checked again in version 10_3_0_pre1 (run320317 RAW): works without problem scram build code-checks gives Warnings:

/afs/cern.ch/user/p/popov/scratch_bk/workDQMthread3/CMSSW_10_3_0_pre1/src/DQM/CastorMoni tor/interface/CastorMonitorModule.h:82:8: warning: annotate this function with 'override ' or (rarely) 'final' [modernize-use-override] void analyze(const edm::Event& iEvent, const edm::EventSetup& eventSetup); ^ ~ override

which annotation must be: 'override' or 'final' ?

andrius-k · 2018-08-08T08:54:28Z

Hi,

Yes the code seems to be fine functionally, but code checks still fail because of the styling issues. In particular it seems that you removed override statements from the methods which are actually overriding base class methods. Please see this bot comment. Override statements usually have no impact on functionality but they are good tool to avoid errors in the future, and they are required by CMSSW policy.

cmsbuild · 2018-08-27T13:54:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-08-27T13:56:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24142/6176

cmsbuild · 2018-08-27T13:56:43Z

Pull request #24142 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

andrius-k · 2018-08-27T14:05:23Z

please test

cmsbuild · 2018-08-27T14:05:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30070/console Started: 2018/08/27 16:07

cmsbuild · 2018-08-27T16:16:16Z

+1
Tested at: 507d5dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24142/30070/summary.html

cmsbuild · 2018-08-27T16:16:20Z

Comparison job queued.

cmsbuild · 2018-08-27T17:41:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24142/30070/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2992641
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2992425
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1145.149 KiB( 30 files compared)
DQMHistoSizes: changed ( 136.85,... ): 28.180 KiB Castor/average E(digi) in BXtrig
DQMHistoSizes: changed ( 136.85,... ): 28.176 KiB Castor/average E(digi) in BX
DQMHistoSizes: changed ( 136.85,... ): 4.043 KiB Castor/E(digi)vsTriggerIndex
DQMHistoSizes: changed ( 136.85,... ): -2.339 KiB Castor/CastorLEDMonitor
DQMHistoSizes: changed ( 136.85,... ): 2.183 KiB Castor/CastorDigiMonitor
DQMHistoSizes: changed ( 136.85,... ): 0.031 KiB Castor/CastorEventProducts
DQMHistoSizes: changed ( 136.85,... ): -0.002 KiB Castor/CastorRecHitMonitor
Checked 129 log files, 14 edm output root files, 31 DQM output files

andrius-k · 2018-08-28T11:43:07Z

+1

cmsbuild · 2018-08-28T11:43:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

andrius-k · 2018-08-28T11:44:01Z

Thank you for applying the the styling rules. Now code looks much nicer!

kpedro88 · 2018-08-28T12:37:59Z

+1

slava77 · 2018-09-28T17:21:06Z

DQM/CastorMonitor/src/CastorDigiMonitor.cc

+int ChannelStatus[14][16];
+int N_GoodChannels = 224;
+int EtowerLastModule = 5;
+int TrigIndexMax = 0;


why were the non-const global statics accepted as OK for production code?
@fabiocos please take a note

fabiocos · 2018-10-02T08:59:50Z

@slava77 thanks for catching the problem

castor dqm update

ab3045e

cmsbuild added this to the CMSSW_10_3_X milestone Jul 31, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 31, 2018

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 31, 2018

castor dqm update

9fb8dfc

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 31, 2018

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 31, 2018

castor dqm update

6bca683

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 31, 2018

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 31, 2018

Castor dqm update

9336bb9

cmsbuild added the tests-pending label Aug 27, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 27, 2018

cmsbuild added tests-approved and removed tests-started labels Aug 27, 2018

cmsbuild added comparison-available and removed comparison-pending labels Aug 27, 2018

cmsbuild removed the dqm-pending label Aug 28, 2018

cmsbuild added dqm-approved fully-signed and removed pending-signatures labels Aug 28, 2018

cmsbuild added orp-approved and removed orp-pending labels Aug 28, 2018

cmsbuild merged commit 4336c71 into cms-sw:master Aug 28, 2018

slava77 reviewed Sep 28, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

castor dqm update #24142

castor dqm update #24142

popovvp commented Jul 31, 2018 •

edited

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

andrius-k commented Aug 7, 2018

popovvp commented Aug 8, 2018 via email •

edited

andrius-k commented Aug 8, 2018

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

andrius-k commented Aug 27, 2018

cmsbuild commented Aug 27, 2018 •

edited

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

andrius-k commented Aug 28, 2018

cmsbuild commented Aug 28, 2018

andrius-k commented Aug 28, 2018

kpedro88 commented Aug 28, 2018

slava77 Sep 28, 2018

fabiocos commented Oct 2, 2018

castor dqm update #24142

castor dqm update #24142

Conversation

popovvp commented Jul 31, 2018 • edited

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

andrius-k commented Aug 7, 2018

popovvp commented Aug 8, 2018 via email • edited

andrius-k commented Aug 8, 2018

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

andrius-k commented Aug 27, 2018

cmsbuild commented Aug 27, 2018 • edited

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

cmsbuild commented Aug 27, 2018

andrius-k commented Aug 28, 2018

cmsbuild commented Aug 28, 2018

andrius-k commented Aug 28, 2018

kpedro88 commented Aug 28, 2018

slava77 Sep 28, 2018

Choose a reason for hiding this comment

fabiocos commented Oct 2, 2018

popovvp commented Jul 31, 2018 •

edited

popovvp commented Aug 8, 2018 via email •

edited

cmsbuild commented Aug 27, 2018 •

edited