Fixed static analizer warnings #24144
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24144/5834 |
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/CustomPhysics @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24144/5837 |
|
Pull request #24144 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24144/5838 |
|
The tests are being triggered in jenkins. |
|
Pull request #24144 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| pmanager->RemoveProcess(0); | ||
| pmanager->AddProcess(new MonopoleTransportation(mpl,chordFinderSetter,verbose), | ||
| -1, 0, 0); | ||
| G4int idxt(0); |
There was a problem hiding this comment.
@civanch out of curiosity, why? It looks to me pure aesthetics, is there any real utility in this change?
There was a problem hiding this comment.
@fabiocos , this may be false positive warning. The problem is in two methods of Genat4 class RevoveProcess(..), in first the argument int, in another G4VProcess*. If the value is 0, compiler may be confused which one to choose.
There was a problem hiding this comment.
@civanch ok, thank you for the clarification, I see the reason
|
+1 |
Trivial clean-up of SIM libraries. Use LogVerbatim instead of LogInfo, use edm::Exception at initialisation. No change is expected.