Avoid ROOT6 limitation by replaceing LinkDef files with xml specs. #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X. Avoid ROOT6 limitation by replaceing LinkDef files with xml specs. It involves the following packages: SimDataFormats/CaloHit @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks. |
davidlt
added a commit
that referenced
this pull request
Feb 12, 2014
Avoid ROOT6 limitation by replaceing LinkDef files with xml specs.
ggovi
pushed a commit
to ggovi/cmssw
that referenced
this pull request
Jan 11, 2017
updates sherpa to 2.2.1 in 81x stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes many (possibly all) cases of two errors in the ROOT6 relvals.
One error is:
Could not find the StreamerInfo for version 9 of the class TBranchElement, object skipped at offset 344
The other error is:
0 violated at line 988 of `/build/cmsbuild/jenkins-workarea/workspace/ib-CMSSW_7_1_ROOT6_X-slc5_amd64_gcc481/237/w/BUILD/slc5_amd64_gcc481/lcg/root/5.99.06/root-5.99.06/io/io/src/TStreamerInfo.cxx'
With this fix, the tests that failed for these reasons fail at a later stage due to other errors. One of the other errors (seen in relval 25.0) is related to this fix However, this fix still needs to be merged, as 25.0 now fails much earlier in its execution. So, this is progress in ROOT6 land.