Protecting E/gamma Scale and Smearing from "nan" energies : 102X

[Sam-Harper]

102X flavour of #24093

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_10_2_X.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Protecting E/gamma Scale and Smearing from "nan" energies : 103X #24093

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29605/console Started: 2018/08/01 16:40

[cmsbuild]

+1
Tested at: 2e48433
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24154/29605/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24154/29605/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892884
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892693
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #24154 2e48433

• the implementation is in line with the PR description. This presently should affect only very rare cases with NaN inputs and (most likely) leading to a crash as reported in https://its.cern.ch/jira/browse/CMSCOMPPR-3266.
  • the backport from the master is correct: the same topic branch is used
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

backport of #24093

[slava77]

type bugfix

[fabiocos]

+1