MTD simulation update #24157
MTD simulation update #24157
Conversation
- removed the time of flight subtraction; - fixed the assignment of the DataFrame buckets; - added correlations between the two times that are read out. ETL code: - removed the time of flight subtraction; - removed the linear interpolation of times in the same cell; - fixed the assignment of the DataFrame buckets; - added a time smearing depending on module eta.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24157/5851 |
|
A new Pull Request was created by @casarsa (Massimo Casarsa) for master. It involves the following packages: SimFastTiming/FastTimingCommon @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 22434.0 |
|
The tests are being triggered in jenkins. |
| @@ -68,6 +90,11 @@ void ETLElectronicsSim::runTrivialShaper(ETLDataFrame &dataFrame, | |||
| newSample.set(chargeColl[it] > adcThreshold_MIP_,false,tdc_time,adc); | |||
| dataFrame.setSample(it,newSample); | |||
|
|
|||
| //std::cout << it << " " << chargeColl[it] << " " << toa[it] << std::endl; | |||
There was a problem hiding this comment.
delete commented-out code and extra lines
There was a problem hiding this comment.
Thank you, I missed this. Done.
|
@kpedro88 I've tested the workflow 22434.0: |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24157/5855 |
|
Pull request #24157 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again. |
|
Pull request #24157 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again. |
|
please test workflow 22434.0 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@kpedro88 Workflow 22434.0 tested: |
|
+upgrade |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
BTL code:
ETL code:
The complete workflow has been successfully tested on a SingleMuon and TTbar sample with runTheMatrix.