MTD RECO code update #24241
MTD RECO code update #24241
Conversation
- duplicated the BTL and ETL code for the reconstruction of uncalibrated hits; - introduced a global correction for BTL time (time-walk + constant offset); - converted ETL energy from MIPs to MeV.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24241/5944 |
|
A new Pull Request was created by @casarsa (Massimo Casarsa) for master. It involves the following packages: RecoLocalFastTime/FTLCommonAlgos @perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test workflow 22434.0 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24241/6069 |
|
@slava77 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
+1
the endcap energy is down by about a factor of 12 (in agreement with the calibration constant change from 1 to 0.085) barrel and endcap times shifted down, apparently due to the new corrections |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This is an update of the MTD reconstruction, complementary to the pull request #24157:
The updated code has been successfully tested with the workflows 22407.0, 22424.0, and 22434.0.