Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T DQM - Disable ugmt muon spectrum quality tests for eta and pt - 102x #24162

Merged
merged 1 commit into from Aug 7, 2018

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Aug 1, 2018

L1T DQM - Disable ugmt muon spectrum quality tests for eta and pt since they had too many false positives.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_2_X.

It involves the following packages:

DQM/L1TMonitorClient

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Aug 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29613/console Started: 2018/08/01 18:20

@thomreis thomreis changed the title L1T DQM - Disable ugmt muon spectrum quality tests for eta and pt L1T DQM - Disable ugmt muon spectrum quality tests for eta and pt - 102x Aug 1, 2018
@thomreis
Copy link
Contributor Author

thomreis commented Aug 1, 2018

backport of #24163

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24162/29613/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892884
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892686
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.744 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 11624.0,... ): -0.167 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11624.0,... ): -0.146 KiB L1T/EventInfo
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

+1

@cmsbuild cmsbuild merged commit 3c95a95 into cms-sw:CMSSW_10_2_X Aug 7, 2018
@thomreis thomreis deleted the l1t_dqm_qtest_tuning_102x branch August 20, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants