Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup MET significance calculation [94X] #24166

Merged
merged 2 commits into from Aug 15, 2018

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Aug 1, 2018

backport of #24135
(primarily for analysis use)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_4_X.

It involves the following packages:

RecoMET/METAlgorithms

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29616/console Started: 2018/08/01 20:33

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24166/29616/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721221
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@slava77
Copy link
Contributor

slava77 commented Aug 2, 2018

+1

for #24166 0d4de80

  • technical update to speedup execution, mostly significant only in light analysis implementations (expected to be ~invisible in miniAOD)
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7ce6f4f into cms-sw:CMSSW_9_4_X Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants