New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc 8 compiler warnings, change strncpy to memcpy #24170
Conversation
These are not real problems. Should result in identical behavior. Destination in both cases is not really a C string so memcpy is probably a better choice. The compiler is trying to steer away from dangerous C string operations. In these cases, one destination is a FORTRAN array and the other a buffer containing multiple C strings and a structure.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24170/5861 |
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: GeneratorInterface/PartonShowerVeto @smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi, @cmsbuild, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@alberto-sanchez do we still have alpgen-based workflows? |
@fabicos not that I know. I have asked the ME experts in GEN, and they also are not aware of any. |
@Dr15Jones do you have some doubt about this PR? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
These are not real problems. Should result in identical
behavior. Destination in both cases is not really a
C string so memcpy is probably a better choice. The
compiler is trying to steer away from dangerous C
string operations. In these cases, one destination is
a FORTRAN array and the other a buffer containing
multiple C strings and a structure.