Remove obsolete code and configurations in CSC local trigger

[dildick]

The aim of this PR is to make the CSC local trigger easier to understand and maintain, especially for new people in the CSC DPG.

Presently, a dozen functions in the CSCCathodeLCTProcessor related to constructing CLCTs have not been used to simulate collision data since 2007 (or earlier). These obsolete functions and associated configurations should not have to be maintained in the future. They also make it hard to navigate a file with with >3000 lines. It is better to remove them. I am also removing a few obsolete test files.

In future PRs I would like to

• remove an outdated local CSC DQM module
• remove the parameters isTMB07 and isMTCC
• undo the decoupling of CLCTs and LCTs in ME1a and ME1b in upgrade scenarios (an interesting idea ~7 year ago that will not materialize in hardware)
• replace the CSCCLCTPreTriggerBXCollection by CSCCLCTPreTriggerDigiCollection (in trigger and packer)

By the end of the clean-up, the size of CSCCathodeLCTProcessor.cc will be reduced by at least 1500 lines.

There should be no changes with respect to the baseline for this PR.

Attention: @ptcox @tahuang1991 @lpernie

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24171/5862

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29624/console Started: 2018/08/02 09:00

[cmsbuild]

+1
Tested at: fc592e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24171/29624/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24171/29624/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891565
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2891373
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[thomreis]

Hi @dildick
I understand that no data that has been taken will be affected by these changes? This only affects simulation from before the data taking?

[dildick]

@thomreis These functions were implemented for very early MC studies, or emulate data from test-beam studies in 2006. According to the comments in the code: "It was used in numerous CSC test beams and MTCC for firmware-emulator comparisons, but due to a number of known limitations it was never used in Monte Carlo studies." and "Starting with CMSSW_3_1_0, it may no longer give the same results as before since old versions of overloaded < > == operators in CLCTDigi class were discarded." So as I understand, this code has been deprecated since CMSSW_3_1_0 (9 years ago).

It does not affect data taken for physics studies.

[thomreis]

+1
In that case I think this is fine.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[dildick]

For a moment I thought that the configuration CSCTPE_setup_cfi was used in the online DQM, but in fact it was switched off over 4 years ago because it was not working, see dmitrijus@069cc0a.

[fabiocos]

+1