GCC 8 compiler warnings, remove memset

[wddgit]

In CSCSectorReceiver, the memset calls were redundant because
the memory was already zeroed by the default class constructors.

In PileupJetIdentifier, replaced the memset with default member
initializers.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24182/5871

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

DataFormats/JetReco
L1Trigger/CSCTrackFinder

@perrotta, @cmsbuild, @nsmith-, @rekovic, @thomreis, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @TaiSakuma, @ahinzmann, @rappoccio, @rovere, @Martin-Grunewald, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29633/console Started: 2018/08/02 23:09

[cmsbuild]

+1
Tested at: 84585e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24182/29633/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24182/29633/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2891565
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2891374
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #24182 84585e4

• technical for reco (PileupJetIdentifier.h); replacing explicit memset initialization by default initialization.
• jenkins tests pass and comparisons with the baseline show no differences

[fabiocos]

@rekovic @thomreis this looks a technical update, could you please have a look?

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1