New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1DQM: JIRA 326 #24191
L1DQM: JIRA 326 #24191
Conversation
…o reportSummaryMap) changes
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24191/5877 |
A new Pull Request was created by @CarstenHensel (Carsten Hensel) for master. It involves the following packages: DQM/L1TMonitorClient @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@CarstenHensel works on the implementation of quality tests for the caloL2 trigger DQM. |
@@ -93,7 +93,13 @@ | |||
SystemLabel = cms.string("Calo Layer2"), | |||
HwValLabel = cms.string("Stage2CaloLayer2"), | |||
SystemDisable = cms.uint32(0), | |||
QualityTests = cms.VPSet() | |||
QualityTests = cms.VPSet( | |||
cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to the uGT section (around line 337) since it is the uGT that should become red if there is a problem on the link.
please abort test |
Jenkins tests are aborted. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24191/5881 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24191/5882 |
Pull request #24191 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
L1DQM: connect caloLayer2 output to uGT input comparison results to reportSummaryMap