Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS Timing Diamond: DQM update #24213

Merged
merged 2 commits into from Aug 7, 2018

Conversation

nminafra
Copy link
Contributor

@nminafra nminafra commented Aug 6, 2018

This PR introduces a better visualization for HPTDC errors, organizing them per Digitizer Board (DB) and TDC.
Moreover, we add few cosmetic fixes and:

  • test file to run the DQM locally using dat files
  • fix for ctpps_dqm_sourceclient-live_cfg.py to introduce the use of onlineMetaDataDigis

Thanks
@forthommel @dfigueiredo

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

A new Pull Request was created by @nminafra (Nicola Minafra) for master.

It involves the following packages:

DQM/CTPPS
DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@batinkov, @makortel, @forthommel, @jan-kaspar, @thomreis, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29692/console Started: 2018/08/06 22:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24213/29692/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891373
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 26
  • DQMHistoTests: Total successes: 2891155
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 22.176 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 10042.0,... ): 1.848 KiB CTPPS/TimingDiamond
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

+1

@cmsbuild cmsbuild merged commit c04c595 into cms-sw:master Aug 7, 2018
cmsbuild added a commit that referenced this pull request Aug 31, 2018
…10_2_1

PPS Timing Diamond: DQM update; backport of #24213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants