Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced by PR 23454 (python 2to3 tool lib2to3.fixes.fix_filter) #24248

Merged
merged 1 commit into from Aug 8, 2018

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 8, 2018

#23454 introduced a bug here as in this file filter is a lambda object and not the builtin function.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

PhysicsTools/HeppyCore

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gpetruc
Copy link
Contributor Author

gpetruc commented Aug 8, 2018

+1
I verified that a fwlite macro using matchObjectCollection3 that was ok in 10_1_X and broken in 10_3_0_pre1 runs fine with this fix.
I could also do "please test" but I don't think this is tested anywhere, otherwise we would had seen that it doesn't work.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29741/console Started: 2018/08/08 18:40

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24248/29741/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891469
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2891276
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2018

+1

@gpetruc thank you for catching and fixing this

@cmsbuild cmsbuild merged commit 5d2ce01 into cms-sw:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants