Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DeepFlavour training for 2016 NanoAOD and re-run it #24276

Merged
merged 6 commits into from Aug 14, 2018

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 13, 2018

This PR, from @HeinerTholen / BTV POG, updates the NanoAOD configuration for the 2016 94X re-miniAOD to run an updated training of DeepFlavour.
As far as I know, it is the last outstanding request for this first NanoAOD pass.

The PR to master will come later today or some time tomorrow, with a change from print to print() following #24117

Heiner Tholen and others added 6 commits August 10, 2018 21:11
@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Aug 13, 2018
@gpetruc
Copy link
Contributor Author

gpetruc commented Aug 13, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29800/console Started: 2018/08/13 17:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2018

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gpetruc
Copy link
Contributor Author

gpetruc commented Aug 13, 2018

backport of #24277
(or actually the other way around, but cmsbuild doesn't have a command for forward-port)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24276/29800/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721225
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@gpetruc
Copy link
Contributor Author

gpetruc commented Aug 13, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3fe6660 into cms-sw:CMSSW_9_4_X Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants