Run2-alca137 Change the code for IsoTrkFilter

[bsunanda]

Back porting the PR #23792

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_10_2_X.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@arunhep, @tocheng, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29824/console Started: 2018/08/14 20:28

[cmsbuild]

+1
Tested at: 6b08af9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24286/29824/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24286/29824/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892884
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892691
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[bsunanda]

In that case I shall bring back the constants for this PR and to the back ported one with the same values as suggested by Mariarosaria

[cmsbuild]

Pull request #24286 was updated. @arunhep, @tocheng, @cmsbuild, @franzoni, @pohsun, @lpernie can you please check and sign again.

[bsunanda]

@lpernie @arunhep @fabiocos It matches with the changes in #23792.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29841/console Started: 2018/08/15 16:42

[cmsbuild]

+1
Tested at: 7d66583
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24286/29841/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24286/29841/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892884
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892693
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[mariadalfonso]

@fabiocos @lpernie @deguio

this PR didn't make the https://github.com/cms-sw/cmssw/releases/tag/CMSSW_10_2_3
but it would be good to have it in the 10_2 at next occasion, as we need this updated ALCARECO earliest possible

[deguio]

hi @kpedro88 @fabiocos
please consider this PR. it is fully signed, merged in master and was mentioned at the ORP last Tue.
it was agreed to have this one merged for the next 10_2 build and deployed at T0 at the next occasion.
thanks in advance!

@bsunanda

[kpedro88]

+1

[deguio]

thanks!