python3 compiling cleanup (continued) #24301
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24301/6037 |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: CondCore/Utilities @perrotta, @cmsbuild, @andrius-k, @silviodonato, @kmaeshima, @fwyzard, @schneiml, @monttj, @Martin-Grunewald, @gpetruc, @jfernan2, @slava77, @ggovi, @arizzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
… On Aug 15, 2018, at 10:22 AM, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @davidlange6 (David Lange) for master.
It involves the following packages:
CondCore/Utilities
DQM/Integration
DQMServices/Diagnostic
HLTrigger/Tools
PhysicsTools/PatAlgos
PhysicsTools/PythonAnalysis
RecoLuminosity/LumiDB
@perrotta, @cmsbuild, @andrius-k, @silviodonato, @kmaeshima, @fwyzard, @schneiml, @monttj, @Martin-Grunewald, @gpetruc, @jfernan2, @slava77, @ggovi, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @Martin-Grunewald, @thomreis, @ahinzmann, @threus, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @barvic, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mmusich, @clelange, @HeinerTholen, @batinkov, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The tests are being triggered in jenkins. |
|
|
||
| get_plot1(infile,'totalTime') | ||
| texpreamble = ['\documentclass[10pt,a5paper,landscape]{report}\n', | ||
| '\\usepackage{graphicx}\n', |
There was a problem hiding this comment.
I do not understand the changes here: this line starts with a double back-slash, but not the line above,
while both lines should produce LaTeX text lines starting with a single back-slash each.
??
|
as I explained briefly in the PR, \u has a special meaning. Eg, in python2
>> d='\u'
>> d
'\\u'
whereas in python3
>> d='\u'
File "<stdin>", line 1
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 0-1: truncated \uXXXX escape
>> d='\\u'
>> d
'\\u'
so I believe the behavior is unchanged. I tried a simple test and the output is the same for writing strings to text files if I use '\u....' or '\\u.....'.
…
I do not understand the changes here: this line starts with a double back-slash, but not the line above,
while both lines should produce LaTeX text lines starting with a single back-slash each.
??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Pull request #24301 was updated. @perrotta, @cmsbuild, @andrius-k, @silviodonato, @kmaeshima, @fwyzard, @schneiml, @monttj, @Martin-Grunewald, @gpetruc, @jfernan2, @slava77, @ggovi, @arizzi can you please check and sign again. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
|
+1 |
|
+1 |
|
@davidlange6 a comment for the future: when writing TeX strings in python, I find it easier just to mark them all as raw strings like |
|
+1 |
|
merge |
|
@davidlange6 it would be useful to backport at least the parts of this affecting |
various fixes for invalid python syntax. Main themes