DD Name Unit Test #24326
DD Name Unit Test #24326
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24326/6071 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/Core @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @alja, @jfernan2, @kpedro88, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
| DDName anotherName; | ||
| std::cerr << "\nDDName name=" << name << " id=" << name.id() | ||
| << ", another name=" << anotherName << " id=" << anotherName.id(); | ||
| int a[100000]{}; |
There was a problem hiding this comment.
This should just be uninitialized values. Is that what you want?
There was a problem hiding this comment.
Doing
int a[100000] = {};
Will zero initialize all the elements.
There was a problem hiding this comment.
I misread one of the web sites info. Testing using 'compiler explorer' does show that what you did will initialize all values to 0. Sorry for the incorrect comment.
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
+1 |
|
+upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
+1 |
Note, it is based on #24263 and #24313
@Dr15Jones and @cvuosalo - I'm not sure what was an original requirement behind a DDName design. I think, the unit test demonstrates one usecase: the registry keeps only unique names.