New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hybrid Format SiStrip Zero Suppression algorithm for 2018 PbPb data-taking #24339
Merged
cmsbuild
merged 62 commits into
cms-sw:master
from
CMSTrackerDPG:sistripZSNewAlgoDevHI_103X
Sep 7, 2018
Merged
Changes from 60 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
19e6887
changing parameters and creating the Force Restore method
8cad752
adding display macro
81ab34e
adding baseline comparator
12deba3
adding hybryd generathor method
3b54574
adding HybridFormat Amulation
a213776
adding HybridFormat Amulation, bug fixing
9ac9966
hybrid emulation done + hybrid analyzer
32adf9c
hybrid emulation done + hybrid analyzer
6a7a7ac
committing emulation code final + tester
2c125b8
first implementation of hybrid format zero suppression
2057709
Clean up SiStripZeroSupression and split "merge" version
pieterdavid 9ba51d0
Pedestals and CM subtractors: pass numbers by value
pieterdavid 3650798
auto_ptr to unique_ptr
pieterdavid 9b73c2d
FedZeroSuppression and APVRestorer: interface and whitespace cleanup
pieterdavid 4c641a6
SiStripRawProcessingAlgorithms: uint32_t and uint16_t in interfaces
pieterdavid 6501aed
Document and clean up Processed and Virgin raw processing algorithms
pieterdavid 8ab873e
Document SiStripRawProcessingAlgorithms, cleanup hybrid methods
pieterdavid 7a84df3
SiStripAPVRestorer: interface and other cleanup
pieterdavid d53e07e
SiStripAPVRestorer::DerivativeFollowerRestore indentation
pieterdavid e8c207a
also use digivector_t typedef in src/SiStripRawProcessingAlgorithms.cc
pieterdavid 1753f31
Update configs
pieterdavid 5b135ad
More documentation, simplify ConvertHybridDigiToRawDigiVector signature
pieterdavid 67722ab
re-apply code checks fixes
pieterdavid a7e98be
Add hybrid zero-suppressed mode to the on-demand unpacker
pieterdavid 602e0af
Add scope mode case to ZS
pieterdavid 27321f1
Update configs to changes in SiStripClusterizerFromRaw parameters
CesarBernardes b457689
Revert last commit and use HLT customisation for changes in SiStripCl…
CesarBernardes afb9e1b
Add call to custom function customiseForPR24339HybridFormatSiStripZS …
CesarBernardes b861d8c
Merge branch 'master' into sistripZSNewAlgoDevHI_103X
CesarBernardes b78adcf
Add consistent indentation and use consumes calls missing in the anal…
CesarBernardes bdc86e4
Start name of local variables and data members with lower case letter
CesarBernardes 5aa90a2
Remove superfluous includes and substitute couts by LogTrace/LogWarnings
CesarBernardes 5a2736f
Change analyzers to edm::one and define a fillDescriptions function
CesarBernardes f27d767
Add SharedResources in analyzers since it is used TFileService
CesarBernardes 851bf68
Fix typos, add range for loops in analyzers, and use lower case lette…
CesarBernardes 60467c6
Use consistent variable names and add named constants
CesarBernardes da5639e
Changes in config files:
CesarBernardes 3a0e15e
Apply the following changes:
CesarBernardes 68d2918
Apply the following changes:
CesarBernardes 0f0ef27
Remove commented out codes
CesarBernardes 7374274
Add new era as a clone of era Run2_HI to be used with new Strip Hybri…
CesarBernardes b5d1fb8
Apply the following changes:
CesarBernardes fa2d9ab
Add 10-bit ZS repacking to cmsDriver, and a customise module to inser…
pieterdavid 0eaea27
SiStripHybridFormatAnalyzer: make pedestals variables local, range-ba…
pieterdavid 1997ef7
coding style: type name cmMap -> CMMap
pieterdavid 5d63bc2
Generate siStripBaselineComparator_cfi from fillDescriptions
pieterdavid 0fad6c9
SiStripBaselineComparator: review comments (style, simplifications)
pieterdavid e5fec55
Generate siStripHybridFormatAnalyzer_cfi from fillDescriptions
pieterdavid 8f18c3d
SiStripAPVRestorer: make nTotStripsPerAPV a (static constexpr) member
pieterdavid a41cd51
ClustersFromRawProducer: indentation
pieterdavid 2d8d495
SiStripMergeZeroSuppression: silence a static analyzer warning (varia…
pieterdavid 6216658
rename hybrid emulation customize method to addBeforeRepackZS10
pieterdavid c5b1243
config fixes, customise method for running on hybrid data
pieterdavid 6005756
Merge branch 'master' into sistripZSNewAlgoDevHI_103X
CesarBernardes 7da7570
remove run2_HI_2018 (for relvals, replaced by customisation)
pieterdavid 6b256d8
move non-production plugins to test/
pieterdavid 5fa516e
Fix SiStripBaselineComparator fillDescriptions
pieterdavid bb5576e
Add BuildFile for RecoLocalTracker/SiStripZeroSuppression/test
pieterdavid b3821d1
use fillDescriptions for SiStripMeanCMExtractor
pieterdavid 97603e4
forgot to remove run2_HI_2018 in one place
pieterdavid b462d55
Adjust customisations for separate hybridemulation, repack+zs and rec…
pieterdavid bcf84c8
Fix a regression in SiStripAPVRestorer::cleaner_LocalMinimumAdder
pieterdavid File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the above the setting which reproduces the old behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you need to call this custom function - see at the end of the file:
process = customiseForPR24339HybridFormatSiStripZS(process)