Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.3.X][Update GTs] new JEC MC TAGs + 2D Pixel Templates + EcalSimPulseShape + L1 menu #24381

Merged
merged 3 commits into from Aug 28, 2018

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Aug 23, 2018

Added JEC MC and EcalSimPulseShape to the following MC GTs

RunI simulation

RunII simulation

Upgrade

2017_MC

Added EcalSimPulseShape and new L1 menu to the following data GTs

RunII data

Added EcalSimPulseShape, Pixel2DTemplate and correct CTPPS geometry to the following data GTs

RunI data

RunII data

Added EcalSimPulseShape, Pixel2DTemplate, new L1 menu and correct CTPPS geometry to the following data GTs

RunII data

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/AlCa

@arunhep, @tocheng, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Aug 23, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30029/console Started: 2018/08/24 01:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24381/30029/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 924 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2987459
  • DQMHistoTests: Total failures: 6580
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2980689
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Aug 24, 2018

+1

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #24381 was updated. @arunhep, @tocheng, @cmsbuild, @franzoni, @pohsun, @lpernie can you please check and sign again.

@tocheng
Copy link
Contributor Author

tocheng commented Aug 24, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30051/console Started: 2018/08/25 01:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24381/30051/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 740 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2992850
  • DQMHistoTests: Total failures: 5542
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2987118
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Aug 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants