Run2-hcx183 Try remove some comments from Static Analyzer reported in #24361 #24386
Conversation
|
The code-checks are being triggered in jenkins. |
bsunanda
changed the title
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24386/6159 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HcalCommonData @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| std::vector<CaloHit> caloHitCache; | ||
| std::vector<int> group_, tower_; | ||
| int nGroup, nTower; | ||
| std::vector<CaloHit> caloHitCache; |
There was a problem hiding this comment.
@bsunanda - please, rename all private members to have trailing underscore for consistency.
| int nGroup, nTower; | ||
| std::vector<CaloHit> caloHitCache; | ||
| std::vector<int> group_, tower_; | ||
| int nGroup, nTower; |
There was a problem hiding this comment.
@bsunanda - please, rename all private members to have trailing underscore for consistency.
| unsigned int count; | ||
| double edepEB, edepEE, edepHB, edepHE; | ||
| double edepHO, edepl[20]; | ||
| double mudist[20]; // Distance of muon from central part |
There was a problem hiding this comment.
@bsunanda - please, rename all private members to have trailing underscore for consistency.
| double mudist[20]; // Distance of muon from central part | ||
| unsigned int count; | ||
| double edepEB, edepEE, edepHB, edepHE; | ||
| double edepHO, edepl[20]; |
There was a problem hiding this comment.
@bsunanda - please, rename all private members to have trailing underscore for consistency.
| double edepl[20]; | ||
| double mudist[20]; // Distance of muon from central part | ||
| unsigned int count; | ||
| double edepEB, edepEE, edepHB, edepHE; |
There was a problem hiding this comment.
@bsunanda - please, rename all private members to have trailing underscore for consistency.
| double edepEB, edepEE, edepHB, edepHE, edepHO; | ||
| double edepl[20]; | ||
| double mudist[20]; // Distance of muon from central part | ||
| unsigned int count; |
There was a problem hiding this comment.
@bsunanda - please, rename all private members to have trailing underscore for consistency.
|
+1 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24386/6177 |
|
The tests are being triggered in jenkins. |
|
Pull request #24386 was updated. @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @civanch can you please check and sign again. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
No description provided.