New CSCBaseboard class and helper function in CSCDetId

[dildick]

Addition of a helper function in CSCDetId that returns the name of a CSC, e.g. ME+1/1/9, the 9th chamber on the positive endcap of the ME1/1 ring.

This function will replace half a dozen snippets that look like:

    if (infoV >= 0) edm::LogError("L1CSCTPEmulatorSetupError")
      << "+++ ME" << ((theEndcap == 1) ? "+" : "-")
      << theStation << "/" << theRing << "/" << theChamber

The second addition is a new base class CSCBaseboard which will contain members common to all TMBs and processors. While there is no physical equivalent of a CSCBaseboard, it will reduce a lot of code duplication. The TMBs and processors do not inherit from the base class yet. I will change that very soon.

@tahuang1991 @lpernie

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24403/6200

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/MuonDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @trocino, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @ptcox, @rovere, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24403/6201

[cmsbuild]

Pull request #24403 was updated. @cmsbuild, @civanch, @mdhildreth, @nsmith-, @rekovic, @thomreis can you please check and sign again.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24403/6203

[cmsbuild]

-1

Tested at: 703239e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24403/30205/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 2 hours.

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30207/console Started: 2018/09/02 18:55

[cmsbuild]

+1
Tested at: 703239e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24403/30207/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24403/30207/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3143879
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3143681
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[dildick]

@fabiocos Can you sign, please?

[fabiocos]

@dildick for my information, the new base class seems used nowhere, please correct me if I am wrong. How was it tested, if it was?

[dildick]

@fabiocos It was tested in my branch dildick:from-CMSSW_10_3_X_2018-08-27-1100-remove-smartME1aME1b. Here are all the changes I would like to make in the CSC local trigger (master...dildick:from-CMSSW_10_3_X_2018-08-27-1100-remove-smartME1aME1b). In this branch, all processors and trigger motherboards inherit from CSCBaseboard.

[fabiocos]

+1