Fix CkfTrackCandidates_cfi.py (10_2)

[Martin-Grunewald]

Fix CkfTrackCandidates_cfi.py (10_2)
Based on 10_0_0
Add missing parameter explicitly with default set to reproduce old behaviour.
Needed for ConfDB parsing.

[cmsbuild]

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_2_X.

It involves the following packages:

RecoTracker/CkfPattern

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix CkfTrackCandidates_cfi.py (10_3) #24435

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30199/console Started: 2018/09/01 17:50

[Martin-Grunewald]

backport of #24435

[cmsbuild]

+1
Tested at: 896c9e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24434/30199/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24434/30199/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2985378
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2985186
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[perrotta]

+1

• The missing parameter is accessed in the code as

    reverseTrajectories(conf.existsAs<bool>("reverseTrajectories") && conf.getParameter<bool>("reverseTrajectories")),

and therefore explicitely adding it as "false" in the config reproduces the old behaviour

• Jenkins tests pass with no differences, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1