Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu V3.5 (10_3) #24438

Merged
merged 9 commits into from Sep 4, 2018
Merged

HLT menu V3.5 (10_3) #24438

merged 9 commits into from Sep 4, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

HLT menu V3.5
Based on CMSSW_10_3_X_2018-09-02-2300

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The code-checks are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30212/console Started: 2018/09/03 09:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24438/30212/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143682
  • DQMHistoTests: Total failures: 82
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3143397
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 27.717 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 10824.0,... ): 7.881 KiB HLT/JME
  • DQMHistoSizes: changed ( 10824.0,... ): 1.358 KiB HLT/GeneralHLTOffline
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

Pull request #24438 was updated. @smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30243/console Started: 2018/09/04 13:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

unhold

@Martin-Grunewald
Copy link
Contributor Author

+1

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
Chris, please sign this PR (for addOnTests.py)

@Dr15Jones
Copy link
Contributor

+1
for addOnTests.py

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24438/30243/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143685
  • DQMHistoTests: Total failures: 81
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3143401
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 28.002 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 10824.0,... ): 7.881 KiB HLT/JME
  • DQMHistoSizes: changed ( 10824.0,... ): 1.453 KiB HLT/GeneralHLTOffline
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Sep 4, 2018

+1

@cmsbuild cmsbuild merged commit 82ac0ab into cms-sw:master Sep 4, 2018
@Martin-Grunewald Martin-Grunewald deleted the IB_HLT_V3p5_103X branch November 17, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants